Review: Needs Fixing
Hello,
I do have some comments on the merge proposal.
account_bank_statement.py
self.message_append_note(cr, uid, ids, ... -> self.message_append_note(cr, uid,
[st.id], ...
account_invoice
self.message_append_note(cr, uid, ids, ... -> self.message_append_note(cr, uid,
[inv_id], ...
event.py
all [..]_send_not method: no need to loop on ids here ! For example :
def create_send_note(self, cr, uid, ids, context=None):
message = _("Event has been <b>created</b>.")
self.message_append_note(cr, uid, ids, body=message, context=context)
return True
"Registration has been <b>draft</b>." -> not an English sentence; ->
"Registration has been set as <b>draft</b>."
mail/res_partner.py
not necessary to explicitly set the context as it is not used in the method
mrp/procurement.py
in check_produce_product: self.message_append_note(cr, uid, [procurement] ->
self.message_append_note(cr, uid, [id], ...
self.running_send_note(cr, uid, ids, context=None) ->
self.running_send_note(cr, uid, ids, context=context)
procurement/procurement.py
all [...]_send_note: no need to loop
project.py
Why did you change "if ('type_id' in vals) or ('remaining_hours' in vals) or
('user_id' in vals) or ('state' in vals) or ('kanban_state' in vals) ?"
project_scrum.py
all [...]_send_note: no need to loop
project_scrum_backlog_sprint.py
in assign_sprint: self.message_append_note(cr, uid, ids, ->
self.message_append_note(cr, uid, [backlog.id], ... (2 times)
purchase_requisition.py
in make_po: add the context to the write
in procurement_pull.py
in action_move_create: add the context to running_send_note as context=context-
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-openchatter/+merge/105647
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-openchatter.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
