Review: Needs Fixing

This will only work correctly if whatever is returned by f.substr(10) is 
already translated. I don't think that fix is correct, isn't the actual issue 
(beyond horrible API) that an underscore is missing on the two original lines 
that were removed? As in, should be 

    this['on_button_' + _t("Save")] = this.on_button_Save;
    this['on_button_' + _t("Close")] = this.on_button_Close;

?
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-574607-cpa/+merge/105067
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1-opw-574607-cpa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to