Review: Needs Fixing

1. Why did you add a `clear` on the Char field? Because the form's `reset` 
event actually resets the original @value attribute? In that case why not do it 
in Field directly so all fields can take advantage of this? Surely they'll all 
have this issue.

2. What is the expected behavior for the select field's clear? That it select 
the empty value right? In that case this is not going to work: the selection 
field may provide its "empty" option as the last one, and this code is going to 
select the *first* one.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-574588-cpa/+merge/104910
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1-opw-574588-cpa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to