Rifakat (OpenERP) has proposed merging 
lp:~openerp-dev/openobject-addons/6.1-opw-574998-rha into 
lp:openobject-addons/6.1.

Requested reviews:
  Naresh(OpenERP) (nch-openerp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-574998-rha/+merge/106781

Hello,

I have corrected return type of _invoice() for field invoice on journal items. 
It was returning
tuple and generating error for Journal Items list view, opened from wizard 
'Manual Reconciliation'. Also removed unneccessary code.

Steps to reproduce it,
1. Create bank statement and encode manual statement line
2. Open wizard 'Manual Reconciliation' from Accounting > Periodical Processing 
> Reconciliation
3. Edit that line, for field 'Invoice', we can only click on 'Open'
4. Receive error while clikcing on Open

Please review this fix.

Regards,
Rifakat Haradwala
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-574998-rha/+merge/106781
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.1-opw-574998-rha.
=== modified file 'account/account_move_line.py'
--- account/account_move_line.py	2012-03-06 16:10:40 +0000
+++ account/account_move_line.py	2012-05-22 11:04:31 +0000
@@ -383,16 +383,8 @@
                         'WHERE l.move_id = i.move_id ' \
                         'AND l.id IN %s',
                         (tuple(ids),))
-        invoice_ids = []
         for line_id, invoice_id in cursor.fetchall():
             res[line_id] = invoice_id
-            invoice_ids.append(invoice_id)
-        invoice_names = {False: ''}
-        for invoice_id, name in invoice_obj.name_get(cursor, user, invoice_ids, context=context):
-            invoice_names[invoice_id] = name
-        for line_id in res.keys():
-            invoice_id = res[line_id]
-            res[line_id] = (invoice_id, invoice_names[invoice_id])
         return res
 
     def name_get(self, cr, uid, ids, context=None):

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to