Xavier ALT (OpenERP) has proposed merging
lp:~openerp-dev/openobject-addons/6.1-opw-574989-xal into
lp:openobject-addons/6.1.
Requested reviews:
Naresh(OpenERP) (nch-openerp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-574989-xal/+merge/106986
Hi,
This MP fix an AccessError when changing "Leave Type" field on an existing
"Leave Request" when new "Leave Type" have a different value of
"double_validation".
As an admin user:
- Install module "hr_holidays"
- Modfify "Compenatory Days", check the "Double validation" field, then Save
- Make sure "demo" user have a employee configured
As demo user:
- Create a new leave request
* description = Test
* leave type = Legal Leaves (so no double validation)
* start date = TODAY
* end date = TODAY
- Save
- Edit and change leave type to "Compensatory Days" (so with double validation)
- Save
Current: raise access on "hr.holiday.status" (i.e. Leave Type)
Expected: no AccessError
Cheers,
Xavier
--
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-574989-xal/+merge/106986
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/6.1-opw-574989-xal.
=== modified file 'hr_holidays/hr_holidays.py'
--- hr_holidays/hr_holidays.py 2012-01-03 13:52:24 +0000
+++ hr_holidays/hr_holidays.py 2012-05-23 11:23:23 +0000
@@ -136,7 +136,7 @@
'category_id': fields.many2one('hr.employee.category', "Category", help='Category of Employee'),
'holiday_type': fields.selection([('employee','By Employee'),('category','By Employee Category')], 'Allocation Type', help='By Employee: Allocation/Request for individual Employee, By Employee Category: Allocation/Request for group of employees in category', required=True),
'manager_id2': fields.many2one('hr.employee', 'Second Approval', readonly=True, help='This area is automaticly filled by the user who validate the leave with second level (If Leave type need second validation)'),
- 'double_validation': fields.related('holiday_status_id', 'double_validation', type='boolean', relation='hr.holidays.status', string='Apply Double Validation'),
+ 'double_validation': fields.related('holiday_status_id', 'double_validation', type='boolean', relation='hr.holidays.status', string='Apply Double Validation', readonly=True),
}
_defaults = {
'employee_id': _employee_get,
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
