Xavier ALT (OpenERP) has proposed merging
lp:~openerp-dev/openobject-server/6.1-opw-574830-xal into
lp:openobject-server/6.1.
Requested reviews:
Vo Minh Thu (OpenERP) (vmt-openerp)
Related bugs:
Bug #997564 in OpenERP Server: "gunicorn cpu_time_limit setting generates
error"
https://bugs.launchpad.net/openobject-server/+bug/997564
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/6.1-opw-574830-xal/+merge/107012
Hi,
In gunicorn.conf.py, setting new config value are not correctly validated.
Example:
conf['cpu_time_limit'] = '180'
Raising:
2012-05-10 09:11:54,002 14215 ERROR ? gunicorn.error: Error handling request
Traceback (most recent call last):
File "/usr/lib/pymodules/python2.6/gunicorn/workers/sync.py", line 87, in
handle_request
self.cfg.pre_request(self, req)
File "/srv/erp-uat.canonical.com/uat/server/openerp/wsgi/core.py", line 505,
in pre_request
resource.setrlimit(resource.RLIMIT_CPU, (cpu_time +
config['cpu_time_limit'], hard))
TypeError: unsupported operand type(s) for +: 'float' and 'str'
This MP force type checking like it's done on config file loading.
Cheers,
Xavier
--
https://code.launchpad.net/~openerp-dev/openobject-server/6.1-opw-574830-xal/+merge/107012
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-server/6.1-opw-574830-xal.
=== modified file 'openerp/tools/config.py'
--- openerp/tools/config.py 2012-04-23 12:24:07 +0000
+++ openerp/tools/config.py 2012-05-23 13:15:38 +0000
@@ -624,6 +624,8 @@
def __setitem__(self, key, value):
self.options[key] = value
+ if isinstance(self.options[key], basestring) and self.casts[key].type in optparse.Option.TYPE_CHECKER:
+ self.options[key] = optparse.Option.TYPE_CHECKER[self.casts[key].type](self.casts[key], key, self.options[key])
def __getitem__(self, key):
return self.options[key]
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
