Rifakat (OpenERP) has proposed merging
lp:~openerp-dev/openobject-addons/6.0-opw-575071-rha into
lp:openobject-addons/6.0.
Requested reviews:
Olivier Dony (OpenERP) (odo-openerp)
Naresh(OpenERP) (nch-openerp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-575071-rha/+merge/108519
Hello,
Fix problem while opeing any custom report created by base_report_creator.
There were two problems I fixed with custom report,
1. When login through GTK+xmlrpc and any value has None value then it raises
error.
Converted None value to False, to be able to handled by GTK when using
xmlrpc protocol,
netrpc automatically handles None value
2. Restricted result only for ids asked from read(), currently it return all
the values,
that causes sorting error in Web client.
Thanks for your review.
Regards,
Rifakat Haradwala
--
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-575071-rha/+merge/108519
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/6.0-opw-575071-rha.
=== modified file 'base_report_creator/base_report_creator.py'
--- base_report_creator/base_report_creator.py 2012-04-27 10:02:16 +0000
+++ base_report_creator/base_report_creator.py 2012-06-04 05:01:21 +0000
@@ -174,6 +174,14 @@
report = self.pool.get('base_report_creator.report').browse(cr, user, context.get('report_id'), context=context)
cr.execute(report.sql_query)
result = cr.dictfetchall()
+ #Only return result for requested ids, not all from 'report.sql_query'
+ result = [r for r in result if r['id'] in set(ids)]
+
+ #Converting None value to False to be handled when using GTK+xmlrpc
+ for r in result:
+ for key, value in r.items():
+ if value is None:
+ r[key] = False
return result
def search(self, cr, user, args, offset=0, limit=None, order=None, context=None, count=False):
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
