Review: Needs Fixing

seems ok but the *or* part in your code will never be evaluated because '' +',' 
= ','.

(inv_names[invoice_created.id] + ', ' or '')  +  
(picking.sale_id.client_order_ref and picking.sale_id.client_order_ref  + ' : ' 
or '') + picking.name

  inv_names[invoice_created.id] = (picking.sale_id.client_order_ref and 
picking.sale_id.client_order_ref  + ' : ' or '') + picking.name






-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-575053-rha/+merge/107162
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.0-opw-575053-rha.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to