Rifakat (OpenERP) has proposed merging 
lp:~openerp-dev/openobject-addons/6.1-opw-575458-rha into 
lp:openobject-addons/6.1.

Requested reviews:
  Naresh(OpenERP) (nch-openerp)
Related bugs:
  Bug #1008328 in OpenERP Addons: "delivery module incompatible with audittrail"
  https://bugs.launchpad.net/openobject-addons/+bug/1008328

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-575458-rha/+merge/108672

Hello,

When we have installed delivery and sale module and try to subscibe log for 
sale.order,
it raises key error for 'id'.

Steps to produce:
1. install sale and delivery modules
2. create log rule for sale.order
3. create a sales order and perform any operation, it will raise key error.

Delivery module adds 'id' field into sale.order and in audittrail while we 
fetch data(from get_data()),
we explicitly skip storing value for 'id' field and then it tries to log for 
'id'.

I have put additional check while logging the line.

Please review it.

Regards,
Rifakat Haradwala
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-575458-rha/+merge/108672
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.1-opw-575458-rha.
=== modified file 'audittrail/audittrail.py'
--- audittrail/audittrail.py	2012-03-23 14:25:41 +0000
+++ audittrail/audittrail.py	2012-06-05 05:16:19 +0000
@@ -384,6 +384,8 @@
         }
         # loop on all the fields
         for field_name, field_definition in pool.get(model.model)._all_columns.items():
+            if field_name in ('__last_update', 'id'):
+                continue
             #if the field_list param is given, skip all the fields not in that list
             if field_list and field_name not in field_list:
                 continue

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to