Review: Needs Fixing * Comments for the code sections moved around need to be fixed (they were duplicated even though each only pertains to a single branch of the condition, so the first one should have been moved — not copied — and the second one should have been left in place). And the indentation of the extracted code is incorrect. * Don't use _.bind, that's not the code style we're using internally, please use an alias on `this` if you need it within a closure. * The mapping function is called get_field_real_id, the comment talks about "get real field name", which one is it?
Otherwise it seems to look good. -- https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-574895-xal/+merge/107950 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/6.1-opw-574895-xal. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
