Review: Needs Fixing

Don't check on `option` this way (especially not without fixing the 
indentation), instead either:

* default-set to an empty object after the function:

    options = options || {};

* or add the test to the existing condition:

    if (options && options.created && …

first one is probably the better and clearer way to handle this, in case new 
code using `options` is added to the method.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-574186-ado/+merge/104221
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1-opw-574186-ado.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to