Review: Needs Fixing * This patch add 2 new variables but does not declare them, so it creates 2 globals * Behavior of on_ui_change needs to be more formally defined, this ad-hoc crap is not good. Why does it return a deferred when it is is synchronous for example? * Why does _change_int_value call _change_int_ext_value on failure, are semantics correct, are we sure it's never going to recurse? Why not just rollback _change_int_value's alterations of #original_value and #value? -- https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-574229-msh/+merge/104229 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/6.1-opw-574229-msh.
_______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
