Review: Needs Fixing

* Don't use literal jQuery call, use $
* $.find already yields a jquery element, why do you rewrap a jquery element in 
a jquery element?
* Why set filter property even on browsers which are not MSIE? Also is there no 
way to test feature to see if text is rotated, and do rotation differently if 
it is not?
* We have already altered library CSS for text alignment, why not edit again?
* Why set rotation in IE to 0 (horizontal) instead of 3? Other browsers get 
rotation of −60 degrees, which is 300 degrees so pretty close to 270. Would 
make sense for this text to be sideways.
* Did you report to dhtmlx library or find mentions of this bug?
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-574546-msh/+merge/104723
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1-opw-574546-msh.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to