Review: Needs Fixing * Use event delegation, it is cheaper than eagerly finding objects if they are never used * Correctly declare variable, in `on_logout`, `inner_viewmanager` is not declared and will create a global. Same in "on_home" and "on_company_logo" * Fix indentation, it is wrong and inconsistent * on_home and on_company_logo are exact same function, why? * Click events on link (like home and company logo) have default behavior which can be prevented[0], this allows links to remain links instead of be unneeded javascript crap everywhere, please use this. * Also please ensure button from middle click works correctly (I am pretty sure it just can not work with this patch) * Extract testing of view being discardable into dedicated method, exact same thing is written 4 times (and 2 more with variation for process and view)
[0] http://api.jquery.com/event.preventDefault/ -- https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-574224-msh/+merge/105957 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/6.1-opw-574224-msh. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
