Review: Needs Fixing

* filtered_fields is defined but not declared -> patch creates global variable
* filtered_fields is useless, `filter` step can be added to existing processing 
chain, before `map`, no need for `each`
* if non-searchable fields are removed from `this.fields`, is there point in 
keeping filter in XML as well? Is just making XML more complex since fields are 
rendered from `this.fields` no?
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-574881-msh/+merge/106739
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1-opw-574881-msh.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to