Turkesh Patel (openERP) has proposed merging 
lp:~openerp-dev/openobject-addons/trunk-review-dashboards-cleaning-tpa into 
lp:~openerp-dev/openobject-addons/trunk-review-dashboards.

Requested reviews:
  Jigar Amin  (OpenERP) (jam-openerp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-review-dashboards-cleaning-tpa/+merge/109080

remove unnecessary code and comments from this modules

    --> sale
    --> crm
    --> event
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-review-dashboards-cleaning-tpa/+merge/109080
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-review-dashboards.
=== modified file 'crm/board_crm_view.xml'
--- crm/board_crm_view.xml	2012-06-06 11:15:17 +0000
+++ crm/board_crm_view.xml	2012-06-07 07:26:15 +0000
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <openerp>
      <data>
-        <!--My Opportunities Action -->
+        <!-- CRM dashboard -->
         <record model="ir.actions.act_window" id="act_my_oppor">
             <field name="name">My Opportunities</field>
             <field name="res_model">crm.lead</field>
@@ -10,7 +10,6 @@
             <field name="view_id" ref="crm.crm_case_tree_view_oppor"/>
         </record>
 
-        <!--New Lead Tree view Action -->
         <record model="ir.actions.act_window" id="act_crm_tag_tree_view_leads_all">
             <field name="name">New Leads</field>
             <field name="res_model">crm.lead</field>
@@ -19,8 +18,6 @@
             <field name="view_id" ref="crm.crm_case_tree_view_leads"/>
         </record>
 
-        <!-- crm mananger dashboard -->
-         <!--Planned Revenue By User pie graph -->
         <record model="ir.ui.view" id="view_crm_opportunity_stage_graph">
             <field name="name">Opportunities By Stage - Graph</field>
             <field name="model">crm.lead.report</field>
@@ -31,8 +28,7 @@
                     <field name="nbr" operator="+"/>
                 </graph>
             </field>
-        </record><!--CRM Dashboard-->
-        <!--Planned Revenue By User pie graph action-->
+        </record>
 
         <record model="ir.actions.act_window" id="act_opportunity_stage">
             <field name="name">Opportunities By Stage</field>
@@ -69,7 +65,6 @@
             <field name="context">{'search_default_Stage':1}</field>
         </record>
 
-        <!-- Metting calendar Action-->
         <record model="ir.actions.act_window" id="crm_case_confirmed_meet">
             <field name="name">Meetings</field>
             <field name="res_model">crm.meeting</field>
@@ -79,7 +74,7 @@
             <field name="domain">[('state','=','open'),('date','&gt;',datetime.date.today().strftime("%Y-%m-%d %H:%M:%S"))]</field>
             <field name="search_view_id" ref="view_crm_case_meetings_filter"/>
         </record>
-        <!--CRM Dashboard-->
+
         <record model="ir.ui.view" id="board_crm_statistical_form">
             <field name="name">CRM - Statistical Dashboard Form</field>
             <field name="model">board.board</field>
@@ -101,7 +96,6 @@
             </field>
         </record>
 
-        <!--CRM Dashboard Action-->
         <record model="ir.actions.act_window" id="open_board_statistical_dash">
             <field name="name">CRM Dashboard</field>
             <field name="res_model">board.board</field>
@@ -111,7 +105,6 @@
             <field name="view_id" ref="board_crm_statistical_form"/>
         </record>
 
-        <!--CRM Dashboard Action-->
         <menuitem
             id="menu_board_statistics_dash"
             parent="base.menu_reporting_dashboard"

=== modified file 'event/board_association_view.xml'
--- event/board_association_view.xml	2012-06-06 10:43:30 +0000
+++ event/board_association_view.xml	2012-06-07 07:26:15 +0000
@@ -1,8 +1,7 @@
 <?xml version="1.0"?>
 <openerp>
     <data>
-    <!--  Need to merge this action in associations -->
-        <!--  This is the view of bar chart-->
+        <!-- Events dashboard -->
         <record model ="ir.ui.view" id="view_report_event_reg_graph">
             <field name="name">Registration Event report</field>
             <field name="model">report.event.registration</field>
@@ -16,7 +15,7 @@
                 </graph>
             </field>
         </record>
-        <!--  This is the Action of bar chart-->
+
         <record  model="ir.actions.act_window" id="act_event_reg">
             <field name="name">Events Filling Status</field>
             <field name="res_model">report.event.registration</field>
@@ -26,7 +25,6 @@
             <field name="view_id" ref="view_report_event_reg_graph"/>
         </record>
 
-        <!--  Action for the tree view of the Events-->
         <record model="ir.actions.act_window" id="act_event_view">
             <field name="name">Next Events</field>
             <field name="type">ir.actions.act_window</field>
@@ -35,7 +33,7 @@
             <field name="view_mode">tree,form</field>
             <field name="domain">[('state','not in',('cancel','done'))]</field>
         </record>
-         <!--  Action for the tree view of New Registration -->
+
         <record model="ir.actions.act_window" id="act_event_view_registration">
             <field name="name">New Registration</field>
             <field name="type">ir.actions.act_window</field>
@@ -44,7 +42,7 @@
             <field name="view_mode">tree,form</field>
             <field name="domain">[('state','=','draft')]</field>
         </record>
-        <!-- Board Association view-->
+
         <record model="ir.ui.view" id="board_associations_manager_form">
             <field name="name">board.associations.manager.form</field>
             <field name="model">board.board</field>
@@ -54,16 +52,16 @@
                     <board style="2-1">
                         <column>
                             <action string="Next Events" name="%(act_event_view)d"/>
-                            <action string="New Registrations" name="%(act_event_view_registration)d"/>    
+                            <action string="New Registrations" name="%(act_event_view_registration)d"/>
                         </column>
-                        <column>    
-                            <action string="Events Filling By Status" name="%(act_event_reg)d"/>            
+                        <column>
+                            <action string="Events Filling By Status" name="%(act_event_reg)d"/>
                         </column>
                     </board>
                 </form>
             </field>
         </record>
-        <!-- Board Association Action-->
+
         <record model="ir.actions.act_window" id="open_board_associations_manager">
             <field name="name">Events Dashboard</field>
             <field name="res_model">board.board</field>

=== modified file 'sale/board_sale_view.xml'
--- sale/board_sale_view.xml	2012-06-06 11:15:17 +0000
+++ sale/board_sale_view.xml	2012-06-07 07:26:15 +0000
@@ -73,9 +73,9 @@
         </record>
 
         <menuitem id="menu_dashboard_sales"
-                  sequence="8" 
-                  parent="base.menu_reporting_dashboard" 
-                  action="open_board_sales" 
+                  sequence="8"
+                  parent="base.menu_reporting_dashboard"
+                  action="open_board_sales"
                   groups="base.group_sale_salesman"/>
 
     </data>

=== modified file 'sale/report/sale_report_view.xml'
--- sale/report/sale_report_view.xml	2012-06-05 06:13:34 +0000
+++ sale/report/sale_report_view.xml	2012-06-07 07:26:15 +0000
@@ -131,32 +131,5 @@
     <menuitem id="base.next_id_64" name="Sales" parent="base.menu_reporting" sequence="1" groups="base.group_sale_manager"/>
     <menuitem action="action_order_report_all" id="menu_report_product_all" parent="base.next_id_64" sequence="10"/>
 
-    <!--This views used in board_sale module -->
-
-	<record id="view_top_quotations_tree" model="ir.ui.view">
-		<field name="name">sale.top.quotations.tree</field>
-		<field name="model">sale.order</field>
-		<field name="type">tree</field>
-		<field name="arch" type="xml">
-			<tree string="Quotations">
-				<field name="date_order"/>
-				<field name="name"/>
-				<field name="partner_id"/>
-				<field name="user_id" />
-				<field name="amount_untaxed" />
-				<field name="amount_total"/>
-			</tree>
-		</field>
-	</record>
-
-    <record id="action_quotation_for_sale" model="ir.actions.act_window">
-        <field name="name">Quotations</field>
-        <field name="res_model">sale.order</field>
-        <field name="view_type">form</field>
-        <field name="view_mode">tree,form</field>
-        <field name="domain">[('state','=','draft')]</field>
-        <field name="view_id" ref="view_top_quotations_tree"/>
-    </record>
-
 </data>
 </openerp>

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to