Review: Needs Fixing

* I'd use `self` to go fetch the action mapping, it's more flexible than 
hardcoding the class name
* I'd also avoid rebinding `action_model`, by renaming the first one to 
`action_type` for instance (which is what it is at this point)
* And a small comment to explain the purpose of the mapping probably wouldn't 
hurt.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-1003923-niv/+merge/109155
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1-1003923-niv.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to