Review: Needs Fixing

It will be good if you have try ...except block for the move_to call...i.e 


-                res = fnode.move_to(cr, dnode or fnode.parent, 
vals.get('name', fbro.name), fbro, dbro, True)
+                try :
+                    res = fnode.move_to(cr, dnode or fnode.parent, 
vals.get('name', fbro.name), fbro, dbro, True)
+                except Exception, e:
+                     raise orm.except_orm(_('Error'), str(e))
                 if isinstance(res, dict):
                     vals2 = vals.copy()
                     vals2.update(res)


Thanks,
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-573644-dhs/+merge/109078
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.1-opw-573644-dhs.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to