Review: Needs Fixing * What is the purpose of the python code this patch is adding? Why can't this be done in javascript * Code does not match guidelines * Some pieces of code don't make any sense, why is the "add to dashboard" input and corresponding submit button in a list item, what's the point? And why are they followed by a ".searchview_extended_delete_prop" link which doesn't even delete anything? * What is the point of setting "menu_data" when it's only ever used *once* in a handler of its retrieval? -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-add_to_dashboard-vme/+merge/109124 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-add_to_dashboard-vme.
_______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
