Ravi Gohil (OpenERP) has proposed merging 
lp:~openerp-dev/openobject-server/6.1-opw-575975-rgo into 
lp:openobject-server/6.1.

Requested reviews:
  Naresh(OpenERP) (nch-openerp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/6.1-opw-575975-rgo/+merge/111007

Hello,

String shown in the wizard which is popped up after completion of 
upgrade/Install module, is not being translated.

I found the overridden fields_view_get() returning the view's `arch` which is 
already been defined in the base_module_upgrade_view.xml file with very minor 
change in view, that is, modified string of the Button `Cancel` to `Close`.

Would you please share your views on this fix?

Thanks.
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/6.1-opw-575975-rgo/+merge/111007
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-server/6.1-opw-575975-rgo.
=== modified file 'openerp/addons/base/i18n/base.pot'
--- openerp/addons/base/i18n/base.pot	2012-02-08 00:45:38 +0000
+++ openerp/addons/base/i18n/base.pot	2012-06-19 12:38:24 +0000
@@ -6452,6 +6452,7 @@
 #: view:base.language.install:0
 #: view:base.module.import:0
 #: view:base.module.update:0
+#: view:base.module.upgrade:0
 #: view:publisher_warranty.contract.wizard:0
 #: view:res.request:0
 msgid "Close"

=== modified file 'openerp/addons/base/module/wizard/base_module_upgrade.py'
--- openerp/addons/base/module/wizard/base_module_upgrade.py	2012-02-17 09:15:54 +0000
+++ openerp/addons/base/module/wizard/base_module_upgrade.py	2012-06-19 12:38:24 +0000
@@ -33,37 +33,6 @@
         'module_info': fields.text('Modules to update',readonly=True),
     }
 
-    def fields_view_get(self, cr, uid, view_id=None, view_type='form', context=None, toolbar=False, submenu=False):
-        """ Changes the view dynamically
-         @param self: The object pointer.
-         @param cr: A database cursor
-         @param uid: ID of the user currently logged in
-         @param context: A standard dictionary
-         @return: New arch of view.
-        """
-        res = super(base_module_upgrade, self).fields_view_get(cr, uid, view_id=view_id, view_type=view_type, context=context, toolbar=toolbar,submenu=False)
-        if view_type != 'form':
-            return res
-
-        record_id = context and context.get('active_id', False) or False
-        active_model = context.get('active_model')
-        if (not record_id) or (not active_model):
-            return res
-
-        ids = self.get_module_list(cr, uid, context=context)
-        if not ids:
-            res['arch'] = '''<form string="Apply Scheduled Upgrades">
-                                <separator string="System update completed" colspan="4"/>
-                                <label align="0.0" string="The selected modules have been updated / installed !" colspan="4"/>
-                                <label align="0.0" string="We suggest to reload the menu tab to see the new menus (Ctrl+T then Ctrl+R)." colspan="4"/>
-                                 <separator string="" colspan="4"/>
-                                <newline/>
-                                <button special="cancel" string="Close" icon="gtk-cancel"/>
-                                <button name="config" string="Start configuration" type="object" icon="gtk-ok"/>
-                             </form>'''
-
-        return res
-
     def get_module_list(self, cr, uid, context=None):
         mod_obj = self.pool.get('ir.module.module')
         ids = mod_obj.search(cr, uid, [

=== modified file 'openerp/addons/base/module/wizard/base_module_upgrade_view.xml'
--- openerp/addons/base/module/wizard/base_module_upgrade_view.xml	2011-12-06 16:17:32 +0000
+++ openerp/addons/base/module/wizard/base_module_upgrade_view.xml	2012-06-19 12:38:24 +0000
@@ -50,7 +50,7 @@
             <label align="0.0" string="We suggest to reload the menu tab to see the new menus (Ctrl+T then Ctrl+R)." colspan="4"/>
              <separator string="" colspan="4"/>
                 <newline/>
-                <button special="cancel" string="Cancel" icon="gtk-cancel"/>
+                <button special="cancel" string="Close" icon="gtk-cancel"/>
                 <button name="config" string="Start configuration" type="object" icon="gtk-ok"/>
              </form>
             </field>

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to