Review: Needs Fixing

Sorry, I missed the incorrect map:

   val = map (lambda x: [6,0,[x]], val)
                        ^^^^^^^^^^^^^^

This will transform a value of [1,2,3] into [[6,0,[1]], [6,0,[2]], [6,0,[3]]] 
which is incorrect because only [3] will in fact be saved. You did not notice 
the problem perhaps because you only tested with a single-valued many2many 
value.

I will change this line before merging to:
   val = [(6,0,val)]
which is much simpler anyway.

-- 
https://code.launchpad.net/~openerp-dev/openobject-server/6.1-opw-574360-dhs/+merge/111009
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-server/6.1-opw-574360-dhs.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to