Review: Needs Fixing

1. `typeof` is a unary operator, not a function, the parens are useless.
2. If the value is (potentially) an array, it makes no sense to type-test on 
object. See ManyToOneField's render code
3. The selection field has no business blowing up all defaults for all fields, 
some other field may want and need its array default, it should only retrieve 
its own default value and fix it up if present, again see how the m2o field 
behaves.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-574891-bth/+merge/110045
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1-opw-574891-bth.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to