Review: Approve

> TDE note: not sure this is the best way to do this

An other way would have been to fix `clean_action` to consider `False` as an 
empty dict (or bail out early if action=False).

Also,

    !!$(ev.target).filter('div.oe_menu_counter').length;

could have been replaced by

    $(ev.target).is('div.oe_menu_counter');

or

    $(ev.target).hasClass('oe_menu_counter');
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-mail-state-tde/+merge/111358
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-mail-state-tde.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to