Review: Needs Fixing Hello,
Some remarks on the code ... mainly on models for this first review. Genral remarks - in all files: in the header of new files, please use the date of the file creation: "Copyright (C) 2012-Today OpenERP SA (<http://www.openerp.com>)." - do not use osv.osv, but osv.Model - please add comments ! especially when adding new models; explain the purpose of the model, how to use it, if there is an API to use, .... see mail_thread class in mail_thread.py for an example of documented class. Mail checklist item - model -- name: set as required; string should be 'Item Name' - action_done -- do not use 'if not context ... ' if you do not use the context in the method, just pass it to lower level methods -- propagate the context in write - why do you do 'return self.pool.get("mail.message").get_checklist_items(cr, uid, msg_id, context=context)' ? Mail message in mail_checklist - logger defined but not used ? - why do you define 'get_checklist_items' ? you should use the 'checklist_item_ids' field instead. For the JS part, just add a read_checklit_items(self, cr, uid, ids, context=None) that read the items, according to message whose id = ids - the 'add_checklist_item' method does not seem to be used anywhere Mail thread in mail_checklist - in 'message_append_note_checklist', it seems you don't have to browse on the messages, because you only use the message_ids. You have this information in new_msg_ids, no need to browse. In mail_checklist - why is the res_users model redefined with nothing added ? Mail vote in mail_vote - def get_votes(self, cr, uid, message_id, context=None) should be get_vote_summary(self, cr, uid, ids, context=None) (remember that we always try to work on id list) - vote_subscribe should be called vote_toggle, that either call vote or unvote Feature not present in mail_thread - redefine the '_get_message_ids' function used to compute the 'message_summary' field. Add the number of votes and the overall % of done items in checklists. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-open-chatter-part-4-atp/+merge/108744 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-open-chatter-part-4-atp. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
