Review: Resubmit

-> * Are the !important really necessary? Both of them? 

With out !important placeholder css is override by related input'css, so it is 
necessary.

-> * #afafaf seems kind-of arbitrary, how did you pick it, and can't you re-use 
an existing (already-used) color around the field and extract *that* as a sass 
constant?

Now use color #AFAFB6(which is already used in CSS).
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-placeholder-fix/+merge/114578
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-placeholder-fix.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to