Review: Needs Fixing Hello Atul, can you resolve following problems ?
General Issue: ======================== Error: string of main menu of "Accounting", it should be "Invoices" instead of "Accounting" Error: On creating new record of Refund, generated error like "Could not get field with name 'algorithm' for onchange 'generate_bbacomm(type,reference_type,algorithm,partner_id,reference)'" ERROR: On creating new record of Journal Voucher, generated error like "Could not get field with name 'payment_rate_currency_id' for onchange 'onchange_date(date, currency_id, payment_rate_currency_id, amount, company_id)" ERROR: On open periods (O2m popup) on fiscal year form, generated error like "Uncaught Error: Unknown field state in domain [["state","in",["done"]]]" remove seperator and tips in all wizard. [may be this are reverted during merged with trunk, can you check and correct it] Changes =================================== account/account_view.xml, account/account_invoice_view.xml, account_check_writing/account_voucher_view.xml, account_voucher/voucher_payment_receipt_view.xml, account_voucher/voucher_sales_purchase_view.xml: Not Ok -> remove unneccassary group -> format of xml seem not good. use four space to expand child element account/wizard/account_tax_chart_view.xml @@ -9,8 +9,6 @@: Not Ok. can you revert it, may be this problem occur during merge with trunk account/wizard/account_chart_view.xml @@ -9,11 +9,15 @@ -> rearrange fields: Not Ok. label should be appear inline @@ -25,7 +29,7 @@ -> rename title into "Select an Accounting Setup" : Ok @@ -36,6 +40,7 @@ -> give name string of menu of "Charts of Account": Ok account_budget/account_budget_view.xml -> rearrange fields of "Budget": Not Ok. no need more groups. account_payment/account_payment.py @@ -87,9 +87,9 @@ -> typo in string of *date_scheduled* and *mode*: Ok @@ -98,14 +98,14 @@ -> typo in string of *date_prefered*, *date_created* and *date_done*: Ok -> rename string of *user_id*, "User" to "Responsible": Ok account_payment/account_payment_view.xml @@ -112,16 +112,20 @@ -> rearrange fields of "Payment Order": Not Ok. no need more groups. account_asset/account_asset.py @@ -213,13 +213,13 @@ -> typo in string of *name*, *category_id* : Ok -> typo in string of *purchase_value* : Ok but remove white trailer space @@ -316,6 +316,16 @@ -> add button action to open "Account Entries" of Assert : Ok @@ -331,7 +341,7 @@ -> typo in string of *sequence* : Ok account_asset/account_asset_view.xml -> cleanup assert view: Not Ok, no need to add more group and *name*, *code* and button(to open entries) should be inline. account_followup/wizard/account_followup_print.py @@ -31,7 +31,7 @@ -> typo in string of *followup_id*, "Follow-Up" : Ok @@ -121,10 +121,10 @@ -> typo in string of *email_conf*, *email_body*: Ok account_followup/wizard/account_followup_print_view.xml -> typo and remove separator : Ok account/wizard/account_fiscalyear_close_state.py @@ -30,7 +30,7 @@ -> typo in string of *fy_id*: Ok account/account_view.xml @@ -103,17 +101,23 @@ -> rearrange fields of "Close a Period" : Not Ok. do not remove sheet. no need to add more group. @@ -17,7 +17,6 @@ -> remove sheet in "Fiscal Year" form: Ok but correct xml format after removed sheet @@ -1835,17 +1850,12 @@ -> rearrange fields of "Recurring Entries": Not Ok. no need to add more groups. account/wizard/account_validate_move_view.xml @@ -25,7 +25,7 @@ -> rename string, "Open Journal" to "Post Journal Entries": Ok account_voucher/account_voucher.py @@ -248,6 +248,22 @@ -> new function for function field to compute untax amount : Ok -> new function to get value of voucher line for storing value of untax amount on changes of fields: Ok @@ -261,7 +277,7 @@ -> typo in string of *date*: Ok -> add new field *amount_untaxed* for untaxed amount: Ok @@ -349,28 +371,24 @@ -> correction in compute_tax method to calculate untaxed_amount: Ok account/wizard/account_move_journal.py @@ -102,7 +102,6 @@ -> remove separator "Open Journal Items !" from wizard: Ok account/wizard/account_report_common_view.xml @@ -20,13 +20,13 @@ -> apply attrs for visibility on group "Dates" and "Periods": Ok @@ -395,18 +413,19 @@ -> correction in onchange_price method to calulate untaxed_amount: Ok account_voucher/account_voucher_view.xml @@ -50,16 +50,30 @@ -> rearrange fields in "Voucher" form: Not Ok. correct formating and also no need to add more groups @@ -209,11 +224,11 @@ -> In bank statement form, all buttons in on oe_button_box div: Ok l10n_ch/wizard/bvr_import_view.xml @@ -30,15 +30,15 @@ -> In bank statement form, all buttons in on oe_button_box div: Ok point_of_sale/account_statement_view.xml @@ -105,7 +105,7 @@ -> change string of *user_id" into "Responsible" in case registers: Ok account_sequence/account_sequence.xml @@ -8,7 +8,7 @@ -> change position of *internal_sequence_number* field: Ok account_coda/account_coda_wizard.xml @@ -14,7 +14,7 @@ -> remove string of group: Ok account/wizard/account_subscription_generate.py @@ -28,7 +28,7 @@ -> change string of *date* into "Generate Entries Before": Ok account/account_cash_statement.py @@ -197,7 +197,7 @@ -> change string of *balance_end_cash* into *Total" : Ok Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-accounting-view-imp-atp/+merge/112724 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-accounting-view-imp-atp. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
