Review: Needs Fixing
Hello Amit,
can you correct following points ?
correct notification msg :
=============================
"Repair has been <b>created</b>." ==> "Repair Order for <em>%s</em> has been
<b>created</b>." % (repair.product_id.name)
"Repair has been <b>Started</b>." ==> "Repair Order for <em>%s</em> has been
<b>started</b>." % (repair.product_id.name)
"Invoice is created with <b>%s<b> reference." ==> ("Draft Invoice of %s %s
<b>waiting for validation</b>.") % (repair.invoice_id.amount_total,
repair.invoice_id.currency_id.symbol)
"Repair order has been <b>Confirmed</b>." ==> "Repair Order for <em>%s</em> has
been <b>accepted</b>." % (repair.product_id.name)
"Repair is now <b>Ready</b>." ==> "Repair Order is now <b>ready</b> to repair."
"Repair is now <b>Done</b>." ==> "Repair Order is <b>closed</b>."
Technical improvement:
==========================
1) def set_toinvoiced_send_note(self, cr, uid, ids, context=None):
for repair in self.browse(cr,uid,ids,context):
message = _("Invoice is created with <b>%s<b> reference.") %
(repair.invoice_id.origin)
return self.message_append_note(cr, uid, ids, body=message,
context=context)
it's wrong. correct with
def set_toinvoiced_send_note(self, cr, uid, ids, context=None):
for repair in self.browse(cr, uid, ids, context=context):
message = _("Invoice is created with <b>%s<b> reference.") %
(repair.invoice_id.origin)
self.message_append_note(cr, uid, [repair.id], body=message,
context=context)
return True
2)
- 'product_uom_qty': fields.float('Quantity (Unit of Measure)',
digits=(16,2), required=True),
+ 'product_uom_qty': fields.float('Quantity', digits=(16,2),
required=True),
ok but should add "digits_compute= dp.get_precision('Product UoS')" instead of
fixed digits.
3)
+ <footer>
+ <field name="message_ids" widget="ThreadView"/>
+ </footer>
it should be
<div class="oe_chatter">
<field name="message_ids" widget="mail_thread"/>
</div>
Thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-mrp-repair-apa/+merge/115092
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-mrp-repair-apa.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
