Ravish(OpenERP) has proposed merging 
lp:~openerp-dev/openobject-addons/trunk-bug-1024285-rmu into 
lp:openobject-addons.

Requested reviews:
  OpenERP Core Team (openerp)
Related bugs:
  Bug #1024285 in OpenERP Addons: "wrong tax grouping in invoice"
  https://bugs.launchpad.net/openobject-addons/+bug/1024285

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1024285-rmu/+merge/115727

Hello,


When account for base_code_id, tax_code_id and account_id are equal(same) for 
two diff tax.It is using first tax name and prints wrong tax line. with this 
fix all are working fine.

Thanks..!! 
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1024285-rmu/+merge/115727
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-1024285-rmu.
=== modified file 'account/account_invoice.py'
--- account/account_invoice.py	2012-07-14 23:18:43 +0000
+++ account/account_invoice.py	2012-07-19 13:03:31 +0000
@@ -756,7 +756,7 @@
             for tax in inv.tax_line:
                 if tax.manual:
                     continue
-                key = (tax.tax_code_id.id, tax.base_code_id.id, tax.account_id.id, tax.account_analytic_id.id)
+                key = (tax.tax_code_id.id, tax.base_code_id.id, tax.account_id.id, tax.account_analytic_id.id,tax.name)
                 tax_key.append(key)
                 if not key in compute_taxes:
                     raise osv.except_osv(_('Warning !'), _('Global taxes defined, but they are not in invoice lines !'))
@@ -1658,7 +1658,7 @@
                     val['account_id'] = tax['account_paid_id'] or line.account_id.id
                     val['account_analytic_id'] = tax['account_analytic_paid_id']
 
-                key = (val['tax_code_id'], val['base_code_id'], val['account_id'], val['account_analytic_id'])
+                key = (val['tax_code_id'], val['base_code_id'], val['account_id'], val['account_analytic_id'],val['name'])
                 if not key in tax_grouped:
                     tax_grouped[key] = val
                 else:

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to