Review: Disapprove

Hello,

The HTML body must not be displayed in the composition wizard because it is not 
synchronized with the text version.
Most people want to quickly type in some text, and they do not care about 
HTML/Text and will not pay attention to the 2 versions, even if the original 
text comes from a template. So the only suitable version for quick edit is the 
text one.
If we use both versions, the email is likely to be sent with 2 different 
versions that are not the same! And as the recipient only sees one of the 
versions, there is a high chance they will not see the correct one!

Anyway even with this patch it will not work, as the mail composition wizard 
will not care about the body_html version, since the default subtype for 
composed email is plain text.

The email templating features in 6.0 were not working properly in this respect 
(no sync between HTML/text) and should not be considered a reference.

If someone really needs to do this, they can customize the view of the 
composition wizard as you did in this patch, but they should also be sure to 
include the "subtype" field to allow the user to choose the main version of 
their mail, depending on which one they prefer.

We'll change this in v7.0 when we introduce a WYSIWYG composition widget that 
will allow typing the HTML text directly.
Until then, it is only possible to specify both Text and HTML versions of a 
mail inside an unmodified mail template.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-576697-ado/+merge/114366
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.1-opw-576697-ado.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to