Review: Needs Fixing Can you please complete the valid_view() function (i.e. add the predicates to the corresponding loop)?
E.g. this function is useless (and testing both valid_att_in_graph() and valid_graph_view() is redundant): 284 +def valid_graph_view(arch): 285 + if arch.tag == 'graph': 286 + for pred in [valid_att_in_graph]: 287 + if not pred(arch): 288 + return False 289 + return True But the predicate valid_att_in_graph can be added to the `graph` case in valid_view(). -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-sloppy-rng-jam/+merge/113170 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-sloppy-rng-vmt. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
