Vo Minh Thu (OpenERP) has proposed merging 
lp:~openerp-dev/openobject-server/trunk-all-modules into lp:openobject-server.

Requested reviews:
  Vo Minh Thu (OpenERP) (vmt-openerp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-all-modules/+merge/84107
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-all-modules/+merge/84107
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-server/trunk-all-modules.
=== modified file 'openerp-server'
--- openerp-server	2012-03-16 11:12:18 +0000
+++ openerp-server	2012-08-16 10:55:21 +0000
@@ -92,7 +92,9 @@
 def preload_registry(dbname):
     """ Preload a registry, and start the cron."""
     try:
-        db, registry = openerp.pooler.get_db_and_pool(dbname, update_module=config['init'] or config['update'], pooljobs=False)
+        update_module = True if config['init'] or config['update'] else False
+        db, registry = openerp.pooler.get_db_and_pool(
+            dbname, update_module=update_module, pooljobs=False, force_demo=not config['without_demo'])
 
         # jobs will start to be processed later, when openerp.cron.start_master_thread() is called by openerp.service.start_services()
         registry.schedule_cron_jobs()
@@ -102,7 +104,9 @@
 def run_test_file(dbname, test_file):
     """ Preload a registry, possibly run a test file, and start the cron."""
     try:
-        db, registry = openerp.pooler.get_db_and_pool(dbname, update_module=config['init'] or config['update'], pooljobs=False)
+        update_module = True if config['init'] or config['update'] else False
+        db, registry = openerp.pooler.get_db_and_pool(
+            dbname, update_module=update_module, pooljobs=False, force_demo=not config['without_demo'])
         cr = db.cursor()
         _logger.info('loading test file %s', test_file)
         openerp.tools.convert_yaml_import(cr, 'base', file(test_file), {}, 'test', True)

=== modified file 'openerp/modules/graph.py'
--- openerp/modules/graph.py	2012-01-24 12:42:52 +0000
+++ openerp/modules/graph.py	2012-08-16 10:55:21 +0000
@@ -87,15 +87,19 @@
             for k, v in additional_data[package.name].items():
                 setattr(package, k, v)
 
-    def add_module(self, cr, module, force=None):
-        self.add_modules(cr, [module], force)
+    def add_module(self, cr, module, force_demo=False):
+        self.add_modules(cr, [module], force_demo)
 
-    def add_modules(self, cr, module_list, force=None):
-        if force is None:
-            force = []
+    def add_modules(self, cr, module_list, force_demo=False):
         packages = []
         len_graph = len(self)
         for module in module_list:
+            if force_demo:
+                cr.execute("""
+                    UPDATE ir_module_module
+                    SET demo='t'
+                    WHERE name = %s""",
+                    (module,))
             # This will raise an exception if no/unreadable descriptor file.
             # NOTE The call to load_information_from_description_file is already
             # done by db.initialize, so it is possible to not do it again here.
@@ -121,9 +125,6 @@
                 current.remove(package)
                 node = self.add_node(package, info)
                 node.data = info
-                for kind in ('init', 'demo', 'update'):
-                    if package in tools.config[kind] or 'all' in tools.config[kind] or kind in force:
-                        setattr(node, kind, True)
             else:
                 later.add(package)
                 packages.append((package, info))
@@ -185,18 +186,11 @@
         node.depth = self.depth + 1
         if node not in self.children:
             self.children.append(node)
-        for attr in ('init', 'update', 'demo'):
-            if hasattr(self, attr):
-                setattr(node, attr, True)
         self.children.sort(lambda x, y: cmp(x.name, y.name))
         return node
 
     def __setattr__(self, name, value):
         super(Singleton, self).__setattr__(name, value)
-        if name in ('init', 'update', 'demo'):
-            tools.config[name][self.name] = 1
-            for child in self.children:
-                setattr(child, name, value)
         if name == 'depth':
             for child in self.children:
                 setattr(child, name, value + 1)

=== modified file 'openerp/modules/loading.py'
--- openerp/modules/loading.py	2012-06-11 12:27:58 +0000
+++ openerp/modules/loading.py	2012-08-16 10:55:21 +0000
@@ -152,7 +152,7 @@
 
         models = pool.load(cr, package)
         loaded_modules.append(package.name)
-        if hasattr(package, 'init') or hasattr(package, 'update') or package.state in ('to install', 'to upgrade'):
+        if package.state in ('to install', 'to upgrade'):
             init_module_models(cr, package.name, models)
         pool._init_modules.add(package.name)
         status['progress'] = float(index) / len(graph)
@@ -166,18 +166,19 @@
 
         idref = {}
 
-        mode = 'update'
-        if hasattr(package, 'init') or package.state == 'to install':
+        if package.state == 'to install':
             mode = 'init'
+        else:
+            mode = 'update'
 
-        if hasattr(package, 'init') or hasattr(package, 'update') or package.state in ('to install', 'to upgrade'):
+        if package.state in ('to install', 'to upgrade'):
             if package.state=='to upgrade':
                 # upgrading the module information
                 modobj.write(cr, SUPERUSER_ID, [module_id], modobj.get_values_from_terp(package.data))
             load_init_xml(module_name, idref, mode)
             load_update_xml(module_name, idref, mode)
             load_data(module_name, idref, mode)
-            if hasattr(package, 'demo') or (package.dbdemo and package.state != 'installed'):
+            if package.dbdemo and package.state != 'installed':
                 status['progress'] = (index + 0.75) / len(graph)
                 load_demo_xml(module_name, idref, mode)
                 load_demo(module_name, idref, mode)
@@ -207,9 +208,6 @@
             modobj.update_translations(cr, SUPERUSER_ID, [module_id], None)
 
             package.state = 'installed'
-            for kind in ('init', 'demo', 'update'):
-                if hasattr(package, kind):
-                    delattr(package, kind)
 
         cr.commit()
     
@@ -264,10 +262,7 @@
         if not openerp.modules.db.is_initialized(cr):
             _logger.info("init db")
             openerp.modules.db.initialize(cr)
-            tools.config["init"]["all"] = 1
-            tools.config['update']['all'] = 1
-            if not tools.config['without_demo']:
-                tools.config["demo"]['all'] = 1
+            update_module = True
 
         # This is a brand new pool, just created in pooler.get_db_and_pool()
         pool = pooler.get_pool(cr.dbname)
@@ -277,43 +272,51 @@
 
         # STEP 1: LOAD BASE (must be done before module dependencies can be computed for later steps) 
         graph = openerp.modules.graph.Graph()
-        graph.add_module(cr, 'base', force)
+        graph.add_module(cr, 'base', force_demo)
         if not graph:
             _logger.critical('module base cannot be loaded! (hint: verify addons-path)')
             raise osv.osv.except_osv(_('Could not load base module'), _('module base cannot be loaded! (hint: verify addons-path)'))
 
         # processed_modules: for cleanup step after install
         # loaded_modules: to avoid double loading
+        # After load_module_graph(), 'base' has been installed or updated and its state is 'installed'.
         report = assertion_report.assertion_report()
-        loaded_modules, processed_modules = load_module_graph(cr, graph, status, perform_checks=(not update_module), report=report)
+        loaded_modules, processed_modules = load_module_graph(cr, graph, status, report=report)
 
         if tools.config['load_language']:
             for lang in tools.config['load_language'].split(','):
                 tools.load_language(cr, lang)
 
         # STEP 2: Mark other modules to be loaded/updated
+        # This is a one-shot use of tools.config[init|update] from the command line
+        # arguments. It is directly cleared to not interfer with later create/update
+        # issued via RPC.
         if update_module:
             modobj = pool.get('ir.module.module')
-            if ('base' in tools.config['init']) or ('base' in tools.config['update']):
+            if ('base' in tools.config['init']) or ('base' in tools.config['update']) \
+                or ('all' in tools.config['init']) or ('all' in tools.config['update']):
                 _logger.info('updating modules list')
                 modobj.update_list(cr, 1)
 
+            if 'all' in tools.config['init']:
+                ids = modobj.search(cr, 1, [])
+                tools.config['init'] = dict.fromkeys([m['name'] for m in modobj.read(cr, 1, ids, ['name'])], 1)
+
             _check_module_names(cr, itertools.chain(tools.config['init'].keys(), tools.config['update'].keys()))
 
-            mods = [k for k in tools.config['init'] if tools.config['init'][k]]
-            if mods:
-                ids = modobj.search(cr, SUPERUSER_ID, ['&', ('state', '=', 'uninstalled'), ('name', 'in', mods)])
-                if ids:
-                    modobj.button_install(cr, SUPERUSER_ID, ids)
-
-            mods = [k for k in tools.config['update'] if tools.config['update'][k]]
-            if mods:
-                ids = modobj.search(cr, SUPERUSER_ID, ['&', ('state', '=', 'installed'), ('name', 'in', mods)])
-                if ids:
-                    modobj.button_upgrade(cr, SUPERUSER_ID, ids)
-
-            cr.execute("update ir_module_module set state=%s where name=%s", ('installed', 'base'))
-
+            mods = [k for k in tools.config['init'] if tools.config['init'][k] and k not in ('base', 'all')]
+            ids = modobj.search(cr, SUPERUSER_ID, ['&', ('state', '=', 'uninstalled'), ('name', 'in', mods)])
+            if ids:
+                modobj.button_install(cr, SUPERUSER_ID, ids) # goes from 'uninstalled' to 'to install'
+
+            mods = [k for k in tools.config['update'] if tools.config['update'][k] and k not in ('base', 'all')]
+            ids = modobj.search(cr, SUPERUSER_ID, ['&', ('state', '=', 'installed'), ('name', 'in', mods)])
+            if ids:
+                modobj.button_upgrade(cr, SUPERUSER_ID, ids) # goes from 'installed' to 'to upgrade'
+
+        # Remove that funky global one-shot thingy.
+        for kind in ('init', 'demo', 'update'):
+            tools.config[kind] = {}
 
         # STEP 3: Load marked modules (skipping base which was done in STEP 1)
         # IMPORTANT: this is done in two parts, first loading all installed or
@@ -364,9 +367,6 @@
             # Cleanup orphan records
             pool.get('ir.model.data')._process_end(cr, SUPERUSER_ID, processed_modules)
 
-        for kind in ('init', 'demo', 'update'):
-            tools.config[kind] = {}
-
         cr.commit()
 
         # STEP 5: Cleanup menus 

=== modified file 'openerp/tests/test_html_sanitize.py' (properties changed: +x to -x)
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to