Ravish(OpenERP) has proposed merging 
lp:~openerp-dev/openobject-addons/trunk-bug-1011178-rmu into 
lp:openobject-addons.

Requested reviews:
  Amit Parik (OpenERP) (amp-openerp)
  Ravish(OpenERP) (rmu-openerp)
  OpenERP Core Team (openerp)
Related bugs:
  Bug #1011178 in OpenERP Addons: "account move line  wrong error message"
  https://bugs.launchpad.net/openobject-addons/+bug/1011178

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1011178-rmu/+merge/109610

Hello,

I have improved the error message in account move line's  _update_journal_check 
 method .This will raise when you try to create entry for period which is 
already closed .

Thanks..!!!   
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1011178-rmu/+merge/109610
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-1011178-rmu.
=== modified file 'account/account_move_line.py'
--- account/account_move_line.py	2012-08-07 11:34:14 +0000
+++ account/account_move_line.py	2012-08-23 13:36:24 +0000
@@ -1184,12 +1184,12 @@
         jour_period_obj = self.pool.get('account.journal.period')
         cr.execute('SELECT state FROM account_journal_period WHERE journal_id = %s AND period_id = %s', (journal_id, period_id))
         result = cr.fetchall()
+        journal = journal_obj.browse(cr, uid, journal_id, context=context)
+        period = period_obj.browse(cr, uid, period_id, context=context)
         for (state,) in result:
             if state == 'done':
-                raise osv.except_osv(_('Error!'), _('You cannot add/modify entries in a closed journal.'))
+                raise osv.except_osv(_('Error !'), _('You can not add/modify entries in a closed period %s of journal %s.' % (period.name,journal.name)))                
         if not result:
-            journal = journal_obj.browse(cr, uid, journal_id, context=context)
-            period = period_obj.browse(cr, uid, period_id, context=context)
             jour_period_obj.create(cr, uid, {
                 'name': (journal.code or journal.name)+':'+(period.name or ''),
                 'journal_id': journal.id,

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to