Review: Needs Information Looks good, though I have a small nitpicking question: wouldn't it be more logical for unlink() to pass *all* fields to _store_get_values() rather than None, as it is effectively touching all the fields of the record. This would avoid giving a magical meaning to "None", when we really mean "all"... Could be done quite efficiently (including inherited fields) with this one-liner instead of the current fix: - result_store = self._store_get_values(cr, uid, ids, None, context) + result_store = self._store_get_values(cr, uid, ids, self._all_columns.keys(), context)
Or am I missing something? Thanks! -- https://code.launchpad.net/~openerp-dev/openobject-server/6.1-opw-577292-xal/+merge/121195 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/6.1-opw-577292-xal. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
