Review: Needs Fixing For the record, a log of what we just discussed live:
- l.40: use =like instead of ilike - l.41: watch out, res.lang has no _order so you can't rely on the result ordering - might want to hardcode en_US out of it - l.42,48: use browse for readability - l.50,51: look for domain builder methods in osv.expression, e.g. expression.AND expression.OR - l.61,62: type = 'field' is missing in WHERE clauses - l.60-67: watch out for falsy src/value, need to coerce them to None - l.71,72,76: view_mode="tree,form", view_type="form", views=[(False, 'tree'), (False, 'form')] -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-scrap-translatedialog-fme/+merge/122641 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-scrap-translatedialog-fme. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
