Review: Disapprove

Thanks for the suggestion, Turkesh, but I think this change is too drastic. If 
this change is merged, then a bug fix that requires a new record will not be 
released properly for users who already have the module installed, unless the 
new record is explicitly marked with forcecreate="1". If we mark it that way, 
then that record now has the problem that bug 1023615 originally complained 
about: it can't be deleted without getting recreated when the module is 
upgraded.
I suspect these are the reasons that the default for forcecreate was originally 
switched to True before the 5.0 release.
I reported bug 1023615, and I would rather live with it as is than make this 
change. The current behaviour is more predictable than it would be after this 
change.
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-1023615-tpa/+merge/122656
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-server/trunk-bug-1023615-tpa.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to