Review: Disapprove No, this:
1. Takes completely arbitrary decisions as to when the parent should or should not be refreshed based on pretty much nothing 2. Is not correct on the little it checks for (button labels are alterable *and* translatable, so relying on them most definitely isn't correct) 3. Is pretty definitely at the wrong level of the inheritance tree (it implies the listview has a grandparent form view if its "add" button is labelled "Add", this is incorrect in both directions) 4. Finally, as far as I can see nothing in the views.js patch makes sense. Is it trying to say something along the lines of "if an act_window_close has a `context` key, reload the current view"? Where was this task specified? I can't find it in the tasks list. There's a task "Handling of popups with dialogs" but it's not validated and it has no spec. -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-1031930-pan/+merge/122832 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-bug-1031930-pan. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
