Bhumi Thakkar (Open ERP) has proposed merging 
lp:~openerp-dev/openerp-web/trunk-improve-css-FF-IE-improve-console-button-bth 
into lp:~openerp-dev/openerp-web/trunk-improve-css-FF-IE.

Requested reviews:
  OpenERP R&D Team (openerp-dev)

For more details, see:
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-improve-css-FF-IE-improve-console-button-bth/+merge/126654

Hello,

  this branch to add console methods and remove submit type check in 
do_execute_action method.
Console methods added in 
lp:~openerp-dev/openerp-web/trunk-improve-css-FF-IE-console-methods-bth barnch 
but deleted code after merged in 
lp:~openerp-dev/openerp-web/trunk-improve-css-FF-IE barnch that is the reason 
to create this barnch and removed code (that 1 line)  else if 
(action_data.type=="object" || action_data.type=="submit") {
because it is fixed in 
lp:~openerp-dev/openerp-web/trunk-improve-css-FF-IE-button-action-object-bth 
branch. " || action_data.type=="submit") {" no need this thing.

Thanks.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-improve-css-FF-IE-improve-console-button-bth/+merge/126654
Your team OpenERP R&D Team is requested to review the proposed merge of 
lp:~openerp-dev/openerp-web/trunk-improve-css-FF-IE-improve-console-button-bth 
into lp:~openerp-dev/openerp-web/trunk-improve-css-FF-IE.
=== modified file 'addons/web/static/src/js/coresetup.js'
--- addons/web/static/src/js/coresetup.js	2012-09-27 07:37:37 +0000
+++ addons/web/static/src/js/coresetup.js	2012-09-27 10:34:25 +0000
@@ -3,7 +3,13 @@
  *--------------------------------------------------------*/
 var console;
 if (!console) {
-    console = {log: function () {}};
+    console = {};
+    var noop = function () {};
+    _.each('log error debug info warn assert clear dir dirxml trace group \
+            groupCollapsed groupEnd time timeEnd profile profileEnd count \
+            exception'.split(/\s+/), function (property) {
+        console[property] = noop;
+    });
 }
 if (!console.debug) {
     console.debug = console.log;

=== modified file 'addons/web/static/src/js/views.js'
--- addons/web/static/src/js/views.js	2012-09-27 09:44:58 +0000
+++ addons/web/static/src/js/views.js	2012-09-27 10:34:25 +0000
@@ -1204,7 +1204,7 @@
 
         if (action_data.special) {
             return handler({result: {"type":"ir.actions.act_window_close"}});
-        } else if (action_data.type=="object" || action_data.type=="submit") {
+        } else if (action_data.type=="object") {
             var args = [[record_id]], additional_args = [];
             if (action_data.args) {
                 try {

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to