The reason you provided the patch is good, both from a technical perspective (i.e. does it make sense to duplicate only the child, and make it point to the same parent), and reagrading the provided example (res.users > res.partner).
The code looks pretty shiny. Now to the boring bits: Inherit/inherits and copy() don't have much tests. It would really be awesome if you could provide test cases for the re-implemented (existing) functionality and for the new feature. (This should be easily done using the new testing infrastructure, located (at least for the core) in openerp/tests/.) -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-oe_refactor_signin-rco/+merge/127966 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-oe_refactor_signin-rco. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
