Review: Disapprove

Hello,

The implementation is not clean:
  - do not create a CSS rule, no need to do a custom class/style
  - do not create redundancy in fields; reference_uom_id should be a function 
field
  - instead of creating on_change to fill in name_ref, I would use a generic 
version of monetary fields to allow putting two times the same name field on 
the view.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-uom-usability-tta/+merge/128626
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-uom-usability-tta.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to