Review: Needs Fixing

In my opinion we should change the name to the event and also to the 
on_pager_action function, maybe something like 'pager_action_executed' and 
'execute_pager_action'.

In the init_pager FormView's method we call directly to the 
execute_pager_action function and inside this last function we trigger the 
event to allow other widgets subscribe to the event if they want.

Same on the on_button_deleted function we call directly execute_pager_action.

An example of widget subscribing to the event is the FieldOne2Many, which is 
correctly fixed.

I'm not sure where to call trigger inside execute_pager_action maybe before 
calling the reload method.

Concerning the web_diagram module, proceed like in the FormView, as it is the 
producer of the event.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-trigger-on_pager_action/+merge/129103
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-trigger-on_pager_action.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to