Review: Needs Fixing bug

Hello,

It introduces a serious regression.
When you are creating a record and are not on the first tab, each time you 
loose focus from a field, the notebook jumps to the first tab.

This is an effect of the condition on lines 47-49:

if ((this.notebook.pagecount-1) == this.index || (this.invisible && this.index 
=== this.notebook.$element.tabs('option', 'selected') && this.index!=0)) {
    this.notebook.do_select_first_visible_tab();
}

This is in update_dom() of the page widget.
update_dom() is called on each page, so the first part of the condition 
forcefully return True for one page of the notebook, so 
do_select_first_visible_tab() is called and jumps to the first tab.

-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-577662-bth/+merge/118347
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1-opw-577662-bth.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to