Saurang Suthar(OpenERP) has proposed merging 
lp:~openerp-dev/openobject-addons/trunk-ps-tests-week44-atp-nel_issue_02-ssu 
into lp:~openerp-dev/openobject-addons/trunk-ps-tests-week44-atp.

Requested reviews:
  Atul Patel(OpenERP) (atp-openerp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-ps-tests-week44-atp-nel_issue_02-ssu/+merge/133058

Hello sir,

I have removed on_change_hr_expense_ok() method for hr_expense_ok field as per 
suggestion.

Kindly review it.

Thank you.
Saurang Suthar
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-ps-tests-week44-atp-nel_issue_02-ssu/+merge/133058
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-ps-tests-week44-atp.
=== modified file 'hr_expense/hr_expense.py'
--- hr_expense/hr_expense.py	2012-11-02 17:46:03 +0000
+++ hr_expense/hr_expense.py	2012-11-06 12:56:41 +0000
@@ -236,16 +236,6 @@
         'hr_expense_ok': fields.boolean('Can be Expensed', help="Specify if the product can be selected in an HR expense line."),
     }
 
-    def on_change_hr_expense_ok(self, cr, uid, id, hr_expense_ok):
-
-        if not hr_expense_ok:
-            return {}
-        data_obj = self.pool.get('ir.model.data')
-        cat_id = data_obj._get_id(cr, uid, 'hr_expense', 'cat_expense')
-        categ_id = data_obj.browse(cr, uid, cat_id).res_id
-        res = {'value' : {'type':'service','sale_ok' :False,'categ_id':categ_id }}
-        return res
-
 product_product()
 
 class hr_expense_line(osv.osv):

=== modified file 'hr_expense/hr_expense_view.xml'
--- hr_expense/hr_expense_view.xml	2012-11-05 10:15:38 +0000
+++ hr_expense/hr_expense_view.xml	2012-11-06 12:56:41 +0000
@@ -195,7 +195,7 @@
             <field name="inherit_id" ref="product.product_normal_form_view"/>
             <field name="arch" type="xml">
                 <div name="options" position="inside">
-                    <field name="hr_expense_ok" on_change="on_change_hr_expense_ok(hr_expense_ok)"/>
+                    <field name="hr_expense_ok"/>
                     <label for="hr_expense_ok"/>
                 </div>
             </field>

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to