Review: Needs Fixing
Hello,
Some comments !
In model:
- rename email_to_partner into recipient_partners
- the string of 'email_to' should become 'To (emails)'
- the string of 'email_to_partner' should become 'To (partners)'; its help
'Comma-separated ids of recipient partners (...)'
In tests:
- why did you remove some variables to use self.[...] ? I think this just make
the diff more verbose than necessary
- actually, when viewing the diff, it seems simpler to include the
'email_to_partner' field test into 'test_00_message_compose_wizard'; just reuse
already-created partners (a@a, ...) and play with it, this will lead to less
lines added in the code
- side remark: when comparing lists, you can compare the sets build on those
list, because set comparison is based on content, not the order
Concerning templates, I think you should also update:
- the sale/edi/sale_order_action_data.xml template
- in auth_reset_password: there is a '<field
name="email_to">${object.email}</field>' could it become an email_to_partner?
- in event, there are 2 '<field name="email_to" >${object.email}</field>',
could it become an email_to_partner?
Regards,
Thibault.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-email-template-to-chm/+merge/133132
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-email-template-to-chm.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
