Review: Disapprove

The fix was not clean, I had to do this:

=== modified file 'account/wizard/account_fiscalyear_close.py'
--- account/wizard/account_fiscalyear_close.py  2012-08-07 11:34:14 +0000
+++ account/wizard/account_fiscalyear_close.py  2012-11-12 08:48:12 +0000
@@ -226,7 +226,7 @@
         for account in obj_acc_account.browse(cr, uid, account_ids, 
context={'fiscalyear': fy_id}):
             balance_in_currency = 0.0
             if account.currency_id:
-                cr.execute('SELECT sum(amount_currency) as balance_in_currency 
FROM account_move_line ' \
+                cr.execute('SELECT sum(COALESCE(amount_currency,0.0)) as 
balance_in_currency FROM account_move_line ' \
                         'WHERE account_id = %s ' \
                             'AND ' + query_line + ' ' \
                             'AND currency_id = %s', (account.id, 
account.currency_id.id))

I merged the clean fix.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-opw-576210-port-mma/+merge/132490
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-opw-576210-port-mma.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to