Review: Needs Fixing

Hello,

Actually, the invite wizard sends an email to the invited partners, using 
mail_mail.create(). As mail_mail inherits from mail_message, it will create a 
mail_message. However, this message should not be attached to any document, as 
we are sending an email that will be unlinked as soon as it is send. Therefore, 
the created mail_message should not have any model and res_id.

In mail_message.check_access_rule(), we see that a message without model and 
res_id should be considered as private, and that we should be allowed to create 
a private message, if we can create a message. The issue here is that this rule 
seems to fail (is the condition badly implemented or does the mail_message have 
a model/res_id, I do not know). This is what you should try to fix; your merge 
proposal is not good I think (moreover, where does this default_res_model key 
come from ?).

Best regards,

Thibault.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1075501-api/+merge/134862
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-1075501-api.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : openerp-dev-gtk@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to