Review: Needs Fixing 1. You should not include InvisibilityChangerMixin, it is already included in AbstractField. By including it again you add it's functions a second time in the prototype chain.
2. I don't know your specs for the Followers widget but it seems that your overload of _check_visibility doesn't match the semantic you seem to be wanting. If your goal is to hide it in editable mode and keep the default behaviour otherwise, you should check if actual_mode is not create and apply the change, otherwise you call super. 3. Do not use toggle() on the element. You should use the oe_form_invisible css class. Check the originial _check_visibility() of InvisibilityChangerMixin for an example. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-fix-mailfollower-display-chm/+merge/134879 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-fix-mailfollower-display-chm. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : openerp-dev-gtk@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
