Vidhin Mehta  (OpenERP) has proposed merging 
lp:~openerp-dev/openerp-web/trunk-opw-578475-port-vme into lp:openerp-web.

Requested reviews:
  OpenERP R&D Web Team (openerp-dev-web)

For more details, see:
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-opw-578475-port-vme/+merge/135827

When pass empty input field from advance search view it can throw error.

Demo :- Accounting -> Journal Entries -> Journal Items -> Advance Filter -> 
Select Balance from the field list -> and don't enter anything in input field, 
it will throw traceback.

Solution: In this branch set default value for integer/float widget of 
searchview like GTK and these widget return its type retaled value if blank 
passed.

Back port from 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-578475-msh/+merge/121832
 
branch with changes, thanks to Mohammed Shekha.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-opw-578475-port-vme/+merge/135827
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-opw-578475-port-vme.
=== modified file 'addons/web/static/src/js/search.js'
--- addons/web/static/src/js/search.js	2012-11-21 13:56:57 +0000
+++ addons/web/static/src/js/search.js	2012-11-23 06:54:21 +0000
@@ -1924,7 +1924,8 @@
     },
     get_value: function() {
         try {
-            return instance.web.parse_value(this.$el.val(), {'widget': 'integer'});
+            var val =this.$el.val();
+            return instance.web.parse_value(val == "" ? 0 : val, {'widget': 'integer'});
         } catch (e) {
             return "";
         }
@@ -1948,7 +1949,8 @@
     },
     get_value: function() {
         try {
-            return instance.web.parse_value(this.$el.val(), {'widget': 'float'});
+            var val =this.$el.val();
+            return instance.web.parse_value(val == "" ? 0.0 : val, {'widget': 'float'});
         } catch (e) {
             return "";
         }

=== modified file 'addons/web/static/src/xml/base.xml'
--- addons/web/static/src/xml/base.xml	2012-11-22 13:35:55 +0000
+++ addons/web/static/src/xml/base.xml	2012-11-23 06:54:21 +0000
@@ -1597,10 +1597,10 @@
     <span/>
 </t>
 <t t-name="SearchView.extended_search.proposition.integer">
-    <input type="number" class="field_integer" step="1"/>
+    <input type="number" class="field_integer" value = "0" step="1"/>
 </t>
 <t t-name="SearchView.extended_search.proposition.float">
-    <input type="number" class="field_float" step="0.01"/>
+    <input type="number" class="field_float" value = "0.0" step="0.01"/>
 </t>
 <t t-name="SearchView.extended_search.proposition.selection">
     <select>

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : openerp-dev-gtk@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to