Review: Disapprove Ok then for Christophe changes.
But not for the rest: - there is a cyclic import - the setup.py still mentions openerp.main - the new serve command is still the same mess as before e.g. it is possible to write openerp-server serve --stop-after-init, which doesn't make any sense - the metaclass is useless: no new command will be discovered unless the module defining them is loaded after the Command lass is defined - the openerp-command is already doing what was inteded by Antony's code - it is possible to write openerp-server command, which does nothing, and probably openerp-server whatever. - each subcommand has to do its own parsing, which is dumb -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-minimal-bin-chs/+merge/135898 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-minimal-bin-chs. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
