Review: Needs Fixing Hello,
I know we worked together about this one, but I can't remember why we put a SUPERUSER_ID on attachments reading ... The block about searching followers and the line (partners_to_notify |= set(fo.partner_id for fo in fol_obj.browse(cr, uid, fol_ids, context=context))) is not necessary I think. It could be something like -- followers = [follower for follower in message.follower_ids if message.subtype_id in follower.subtype_ids] -- partners_to_notify |= followers And, well, maybe you could add tests in test_mail_access_rights, with a lambda employee user: - a test about parent message notification creation - a test about reading a message with attachments Cheers! Thibault. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-openchatter-notify-chm/+merge/137228 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-openchatter-notify-chm. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : openerp-dev-gtk@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
