Review: Needs Fixing
Branch works ok, just a minor remark, please try to keep your diff as small as
possible, without noise.
Eg:
+ var $start_column = $('.oe_kanban_groups_records .oe_kanban_column
').eq(start_index);
+ var $stop_column = $('.oe_kanban_groups_records .oe_kanban_column
').eq(stop_index);
you added a space character in the selector. probably a leftover during the
development.
Something else :
+ self.$('.oe_kanban_quick_create').css({ visibility:
'hidden' });
self.$('.oe_kanban_record').css({ visibility: 'hidden'
});
You add a line instead of merging the selectors like this :
self.$('.oe_kanban_record,
.oe_kanban_quick_create').css({ visibility: 'hidden' });
I'm thinking about making a custom jquery plugin out of the bounce effect.
Meanwhile, you can fix those minor remarks.
Thanks.
--
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-misc-fixes/+merge/136851
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/trunk-misc-fixes.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : openerp-dev-gtk@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
